fix: migrate asset id on the frontend in the query editor #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
requested review from
idastambuk and
njvrzm
and removed request for
a team
idastambuk
approved these changes
Aug 27, 2024
kevinwcyu
requested review from
corteggiano,
tracy-french,
diehbria,
hwandersman,
haweston,
ssjagad and
mitchlee-amzn
hwandersman
approved these changes
Aug 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes an issue where dashboards saved with versions before 1.6.0 do not show the selected asset in the query editor after updating to versions 1.6.0+.
The change in 1.6.0 migrated the
asset idtoasset idsonly when the query ran, but the query editor still received the old query with only theassetIdfield populated so it couldn't fetch the asset info correctly.This PR adds a very basic migration function that is called from the query editor. The only migration it implements now is to migrate
assetIdtoassetIds.Which issue(s) this PR fixes:
Fixes #238
Special notes for your reviewer:
I downgraded the SiteWise data source to v1.5.1 on my cloud instance and created a dashboard with a query type that includes the Asset selector. Then I exported the dashboard and imported it locally to test the migration.